[PATCH] D83631: [PredicateInfo] Place predicate info after assume

Mon Jul 13 03:31:14 PDT 2020

nikic marked an inline comment as done.
nikic added inline comments.

================
Comment at: llvm/test/Transforms/NewGVN/assumes.ll:32
   call void @llvm.assume(i1 %cmp)
   br i1 %b, label %bb, label %end

----------------
fhahn wrote:
> The tests in this file do not seem very useful as is.
> 
> Could you add uses of the condition in the `assume` before and after the call to assume, to that we actually make use of the info from the assume properly? It would also be good to add uses for an equivalent `icmp` (i.e. something like `cmp.1 =  icmp eq i32 %a, %arg`)
Right, these are negative test cases that just happen to show this change. The positive ones are in assume-equal.ll and XFAILed. Probably, NewGVN xfail tests should be split into the parts that actually xfail and the parts that do work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83631/new/

https://reviews.llvm.org/D83631