[PATCH] D83631: [PredicateInfo] Place predicate info after assume

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/Transforms/NewGVN/assumes.ll:32
   call void @llvm.assume(i1 %cmp)
   br i1 %b, label %bb, label %end
 
----------------
The tests in this file do not seem very useful as is.

Could you add uses of the condition in the `assume` before and after the call to assume, to that we actually make use of the info from the assume properly? It would also be good to add uses for an equivalent `icmp` (i.e. something like `cmp.1 =  icmp eq i32 %a, %arg`)


================
Comment at: llvm/test/Transforms/Util/PredicateInfo/testandor.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt -print-predicateinfo < %s 2>&1 | FileCheck %s
+; RUN: opt -print-predicateinfo < %s 2>&1 >/dev/null | FileCheck %s
 
----------------
`-disable-output` instead of referencing `/dev/null`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83631/new/

https://reviews.llvm.org/D83631