[PATCH] D83185: [Attributor] Introduce Attribute seed allow list.

[Kuter Dinel via Phabricator via llvm-commits]

kuter updated this revision to Diff 277247.
kuter added a comment.

1. Better comments.
2. Remove unneeded lines from the test.

I investigated the situation with the argument option that this patch introduces.
LLVM CommandLine library already does not allow a empty list but what happens is when you 
pass a empty list for a execution like this `opt --attribute-seed-allow-list`
CommandLine automatically displays an error and terminates execution.
But  when there are other arguments after the option the then that option becomes a member of the list.

It would have been great if we had a way of telling whether a name is valid or not.
Perhaps we could  have a list of valid attribute names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83185/new/

https://reviews.llvm.org/D83185

Files:
  llvm/include/llvm/Transforms/IPO/Attributor.h
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/test/Transforms/Attributor/allow_list.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83185.277247.patch
Type: text/x-patch
Size: 4691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200711/db1f7ee3/attachment.bin>