[PATCH] D83185: [Attributor] Introduce Attribute seed allow list.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

As discussed, we can check for the validity of the list in the constructor. Two more comments below.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1433
+  /// Before the run function gets called.
+  bool SeedingPeriod;
+
----------------
Use more words to describe this please.

Nit: Maybe initialize it directly here.



================
Comment at: llvm/test/Transforms/Attributor/allow_list.ll:37
+
+!0 = !{!"clang version 3.8.1-24 (tags/RELEASE_381/final)"}
----------------
Get rid of all lines we don't need, e.g. the last 5.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83185/new/

https://reviews.llvm.org/D83185