[PATCH] D83394: [AMDGPU] Avoid splitting FLAT offsets in unsafe ways

Fri Jul 10 01:15:45 PDT 2020

foad added a comment.

In D83394#2143122 <https://reviews.llvm.org/D83394#2143122>, @sameerds wrote:

> In D83394#2142277 <https://reviews.llvm.org/D83394#2142277>, @foad wrote:
>
> > Rebase.
> >  Fix silly mistake in checking for negative offsets.
>
>
> It's hard to see through the rebase, but did fixing the negative offset check add more tests? I assuming that the tests in the original patch did not capture this mistake, so it should warrant a new test.

There are no new tests. All the testing comes from staring at the changes in offset-split-flat.ll and offset-split-global.ll.

In retrospect I should have noticed that there was something wrong with the original patch, because it didn't cause any changes in offset-split-flat.ll.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83394/new/

https://reviews.llvm.org/D83394