[PATCH] D83394: [AMDGPU] Avoid splitting FLAT offsets in unsafe ways

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 19:47:50 PDT 2020


sameerds added a comment.

In D83394#2142277 <https://reviews.llvm.org/D83394#2142277>, @foad wrote:

> Rebase.
>  Fix silly mistake in checking for negative offsets.


It's hard to see through the rebase, but did fixing the negative offset check add more tests? I assuming that the tests in the original patch did not capture this mistake, so it should warrant a new test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83394/new/

https://reviews.llvm.org/D83394





More information about the llvm-commits mailing list