[PATCH] D83421: [RFC] MemorySSAUpdater: Simplify applyUpdates

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

This is an issue I am aware of and the main motivation for the DominatorTree refactoring work.  We do need an updated DT here, and currently we're not computing the correct one. This isn't causing issues at the moment because of the scenarios where the updater is being used, but using the current DT in general is not correct.

You're right, it's a very useful optimization now, but some of the cost will be re-added as soon as the infrastructure to update the DT to a PostCFG view is available.
I opted for not removing this now to avoid the confusion of potential performance regressions for the next release, since re-adding the infrastructure needed for correctness will present as a regression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83421/new/

https://reviews.llvm.org/D83421