[PATCH] D83421: [RFC] MemorySSAUpdater: Simplify applyUpdates

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 13:15:59 PDT 2020


nhaehnle added a comment.

This is a weird one that I stumbled upon while looking at dominator tree construction.

CalculateWithUpdates doesn't actually *do* anything with the passed-in updates, so this change should be NFC. Either this is a very useful optimization, or something is rather broken in the MemorySSAUpdater, but I simply don't know it well enough to tell which one it is, so any illumination would be very much appreciated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83421/new/

https://reviews.llvm.org/D83421





More information about the llvm-commits mailing list