[PATCH] D83089: DomTree: Extract (mostly) read-only logic into type-erased base classes

Wed Jul 8 12:00:52 PDT 2020

kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

Thanks for checking this. I dug up some old whole-program bitcode and uploaded it here in case it helps with future code reviews: https://drive.google.com/drive/folders/1VJpym19cW-8BVgdtl2MsD3zB4CoEQ93O?usp=sharing

I did a quick experiment I run the trunk and your patch on a few binaries from each project and got the number below. I only set the performance governor to performance but didn't do anything fancy to fix the clocks, disable SMT, or any core pinning. My machine has two Xeon 6154 Skylake CPUs.

|             | Branch  | Avg. [s] | Std    | Run 1 [s] | Run 2 [s] | Run 3 [s] | Run 4 [s] | Run 5 [s] | Delta [%] |
| ----------- | ------- | -------- | ------ | --------- | --------- | --------- | --------- | --------- | --------- |
| sqlite3.bc  | trunk   | 15.922   | 0.1011 | 15.82     | 15.82     | 15.98     | 15.94     | 16.05     |           |
|             | nicolai | 15.958   | 0.0522 | 15.97     | 16.03     | 15.97     | 15.93     | 15.89     | 0.23%     |
| llvm-as.bc  | trunk   | 207.868  | 2.7855 | 209.82    | 210.73    | 206.72    | 203.69    | 208.38    |           |
|             | nicolai | 207.01   | 1.7279 | 209.37    | 205.98    | 207.75    | 207.12    | 204.83    | -0.41%    |
| wasm-as.bc  | trunk   | 43.596   | 0.2885 | 43.08     | 43.73     | 43.72     | 43.72     | 43.73     |           |
|             | nicolai | 43.696   | 0.1689 | 43.82     | 43.49     | 43.91     | 43.66     | 43.6      | 0.23%     |
| wasm-opt.bc | trunk   | 46.956   | 0.1383 | 47.06     | 47.14     | 46.91     | 46.82     | 46.85     |           |
|             | nicolai | 46.998   | 0.4558 | 46.46     | 46.59     | 47.29     | 47.13     | 47.52     | 0.09%     |
|

Seems performance-neutral to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83089/new/

https://reviews.llvm.org/D83089