[PATCH] D81485: GlobalISel: Verify G_BITCAST changes the type

Wed Jul 8 11:01:17 PDT 2020

aemerson accepted this revision.
aemerson added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/arm64-regbankselect.mir:410
+# FAST-NEXT:   %1:fpr(<4 x s8>) = G_BITCAST %0
+# GREEDY-NEXT: %1:gpr(<4 x s8>) = G_BITCAST %0
 body:             |
----------------
arsenm wrote:
> aemerson wrote:
> > paquette wrote:
> > > AFAIK we should only have vectors on FPRs, but maybe I'm wrong about that.
> > > 
> > > @aemerson ?
> > We never enable the greedy RBS mode. I think this behavior is wrong for vectors.
> For the purpose of the patch, there just needs to be something here to test a bitcast. If it happens to produce the wrong output, that's a separate issue
Please add a comment in this test to explain that the greedy checks are correct.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81485/new/

https://reviews.llvm.org/D81485