[PATCH] D81485: GlobalISel: Verify G_BITCAST changes the type

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 16:56:17 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/arm64-regbankselect.mir:410
+# FAST-NEXT:   %1:fpr(<4 x s8>) = G_BITCAST %0
+# GREEDY-NEXT: %1:gpr(<4 x s8>) = G_BITCAST %0
 body:             |
----------------
aemerson wrote:
> paquette wrote:
> > AFAIK we should only have vectors on FPRs, but maybe I'm wrong about that.
> > 
> > @aemerson ?
> We never enable the greedy RBS mode. I think this behavior is wrong for vectors.
For the purpose of the patch, there just needs to be something here to test a bitcast. If it happens to produce the wrong output, that's a separate issue


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81485/new/

https://reviews.llvm.org/D81485





More information about the llvm-commits mailing list