[PATCH] D83351: [llvm-reduce] Reducing attributes

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D83351#2139586 <https://reviews.llvm.org/D83351#2139586>, @nickdesaulniers wrote:

> I'm not a fan of the inconsistent use of range-for and for-each; I would prefer range-for everywhere since it's more concise.


My (consistently inconsistent) headcanon as to which to use when is that for_each should be used
when in principle we don't care in which order each item will be processed.

> But I don't feel strongly enough to block the patch based on that.  Maybe LLVM's style guide should provide clarity and guidance on the difference of opinion?



> It might be polite to see if other reviewers have additional and timely feedback.

Sure, let's see if @dblaikie / etc have any other comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83351/new/

https://reviews.llvm.org/D83351