[PATCH] D83351: [llvm-reduce] Reducing attributes
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 8 10:36:11 PDT 2020
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.
I'm not a fan of the inconsistent use of range-for and for-each; I would prefer range-for everywhere since it's more concise.
But I don't feel strongly enough to block the patch based on that. Maybe LLVM's style guide should provide clarity and guidance on the difference of opinion?
It might be polite to see if other reviewers have additional and timely feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83351/new/
https://reviews.llvm.org/D83351
More information about the llvm-commits
mailing list