[PATCH] D83351: [llvm-reduce] Reducing attributes
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 16:05:01 PDT 2020
nickdesaulniers added a comment.
In D83351#2137610 <https://reviews.llvm.org/D83351#2137610>, @lebedev.ri wrote:
> In D83351#2137603 <https://reviews.llvm.org/D83351#2137603>, @nickdesaulniers wrote:
>
> > I think it would be good in the description+commit message to reference https://reviews.llvm.org/D73853 (and that it was reverted).
> >
> > Does llvm-reduce still have "interestingness tests" in `llvm/test/Reduce/Inputs/`? If so, shouldn't this change add such a test?
>
>
> *cough* `llvm/test/Reduce/*.ll`
> There are (no more new!) `llvm/test/Reduce/Inputs/*` files because they are pointless.
> As you can see we can just as easily use FileCheck to drive interestingness tests.
Might be worth proving it if you're bored and doing other janitorial work in the area. Having homogeneous tests is nice, since we'd rather future travelers use `FileCheck` for BOTH interesting-ness and functional testing of their reduction pass itself.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83351/new/
https://reviews.llvm.org/D83351
More information about the llvm-commits
mailing list