[PATCH] D83351: [llvm-reduce] Reducing attributes
    Roman Lebedev via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jul  7 16:01:40 PDT 2020
    
    
  
lebedev.ri added a comment.
In D83351#2137603 <https://reviews.llvm.org/D83351#2137603>, @nickdesaulniers wrote:
> I think it would be good in the description+commit message to reference https://reviews.llvm.org/D73853 (and that it was reverted).
>
> Does llvm-reduce still have "interestingness tests" in `llvm/test/Reduce/Inputs/`? If so, shouldn't this change add such a test?
*cough* `llvm/test/Reduce/*.ll`
There are (no more new!) `llvm/test/Reduce/Inputs/*.ll` files because they are pointless.
As you can see we can just as easily use FileCheck to drive interestingness tests.
> Thanks for the patch!
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83351/new/
https://reviews.llvm.org/D83351
    
    
More information about the llvm-commits
mailing list