[PATCH] D82754: [lit] Prevent hang when lit sees non-ASCII characters

Tue Jul 7 09:09:00 PDT 2020

richard.barton.arm added a comment.

> By "passes", I think you're saying that it doesn't reproduce the error. Right?

Yes, sorry. I was trying to write a test that would fail _without_ my patch applied so had got myself turned around.

> If so, I suspect that llvm-lit called directly uses python2 on your system, but check-all uses python3. Can you confirm?
>  I also suspect this is a python2-specific bug.

Spot on - I can confirm this is what is happening. Thanks for clearing that up for me.

I will push an update with a new comment and my new test. I guess the evilness of it when/if it were to regress is ok - make sure we don't regress I suppose!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82754/new/

https://reviews.llvm.org/D82754