[PATCH] D82754: [lit] Prevent hang when lit sees non-ASCII characters

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D82754#2127919 <https://reviews.llvm.org/D82754#2127919>, @richard.barton.arm wrote:

> Hi @jdenny


Hi.  Sorry for the delay.

> I can make a test that is adapted from shtest-shell/stdout-encoding.txt with this RUN line
> 
>   # RUN: not env PYTHONIOENCODING=ascii %{lit} -j 1 -v %{inputs}/shtest-shell-ascii > %t.out
> 
> 
> which will trigger the error for me when run with llvm-lit without -a (although the failure mode is to hang, so pretty nasty)

Thanks for finding this reproducer!

> but this test passes in make check-all.

By "passes", I think you're saying that it doesn't reproduce the error.  Right?

If so, I suspect that llvm-lit called directly uses python2 on your system, but check-all uses python3.  Can you confirm?

I also suspect this is a python2-specific bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82754/new/

https://reviews.llvm.org/D82754