[PATCH] D83235: [GlobalISel][InlineAsm] Fix matching input constraints to mem operand

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 08:13:47 PDT 2020


Petar.Avramovic marked an inline comment as done.
Petar.Avramovic added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp:417
+            !InlineAsm::isRegDefEarlyClobberKind(MatchedOperandFlag)) {
+          LLVM_DEBUG(dbgs() << "Unknown matching constraint\n");
+          return false;
----------------
arsenm wrote:
> I don't think this case is covered in the test?
That was covered in D82651 but I didn't check the flag and missed to report that isMemKind() was unsupported .


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83235/new/

https://reviews.llvm.org/D83235





More information about the llvm-commits mailing list