[PATCH] D83235: [GlobalISel][InlineAsm] Fix matching input constraints to mem operand

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 13:34:44 PDT 2020


arsenm added a comment.

getPointerRegClass is terrible, but also shouldn't be necessary in GlobalISel since pointer types aren't lost



================
Comment at: llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp:417
+            !InlineAsm::isRegDefEarlyClobberKind(MatchedOperandFlag)) {
+          LLVM_DEBUG(dbgs() << "Unknown matching constraint\n");
+          return false;
----------------
I don't think this case is covered in the test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83235/new/

https://reviews.llvm.org/D83235





More information about the llvm-commits mailing list