[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 07:21:05 PDT 2020


Hahnfeld added a comment.

In D83268#2135930 <https://reviews.llvm.org/D83268#2135930>, @JonChesterfield wrote:

> Aside from the API stability concern this looks uncontentious. Removes dead arguments, generally makes things simpler. Thus LGTM.
>
> @Hahnfeld @ABataev - are you sufficiently persuaded that preserving the current interface is not worth the development cost?


I'm neither, and I've long argued that being able to build the OpenMP runtime(s) without Clang trunk is an important use case. These arguments have gone largely unheard, so I'll not join this discussion once more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83268/new/

https://reviews.llvm.org/D83268





More information about the llvm-commits mailing list