[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

Tue Jul 7 07:07:33 PDT 2020

jdoerfert added a comment.

In D83268#2136055 <https://reviews.llvm.org/D83268#2136055>, @ABataev wrote:

> In D83268#2136054 <https://reviews.llvm.org/D83268#2136054>, @jdoerfert wrote:
>
> > In D83268#2136029 <https://reviews.llvm.org/D83268#2136029>, @ABataev wrote:
> >
> > > `llvm-project/openmp/libomptarget`
> >
> >
> > Please use more words.
>
>
> libomptarget is part of libomp

As mentioned before, no it is not.

Despite the similarity in name, libomp and libomptarget are distinct libraries, this was a conscious design choice.
FWIW, this patch does *not* modify libomptarget either. This modifies *the device runtime*, aka. libomptarget-nvptx-sm_XXX.bc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83268/new/

https://reviews.llvm.org/D83268