[PATCH] D83225: [llvm-readobj] - Refactor the MipsGOTParser<ELFT> to stop using report_fatal_error().

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with message fix.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3077-3084
+  if (!PltSec)
+    return createError("There is no not empty PLTGOT section at 0x " +
+                       Twine::utohexstr(*DtMipsPltGot));
+
+  PltRelSec = findNotEmptySectionByAddress(Obj, FileName, *DtJmpRel);
+  if (!PltRelSec)
+    return createError("There is no not empty RELPLT section at 0x" +
----------------
grimar wrote:
> jhenderson wrote:
> > These two cases don't appear to have tests?
> > 
> > Also, the errors should be "not empty" -> "non-empty" and have lower-case first letters.
> Oh, right. I've missed them for unknown reason. I've added tests for these 2.
not empty -> non-empty

(in both errors still)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83225/new/

https://reviews.llvm.org/D83225