[PATCH] D83225: [llvm-readobj] - Refactor the MipsGOTParser<ELFT> to stop using report_fatal_error().

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3024
+  if (!DtPltGot)
+    return createError("cannot find PLTGOT dynamic table tag");
+  if (!DtLocalGotNum)
----------------
MaskRay wrote:
> The canonical term is dynamic tag, not dynamic table tag.
Fixed.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3077-3084
+  if (!PltSec)
+    return createError("There is no not empty PLTGOT section at 0x " +
+                       Twine::utohexstr(*DtMipsPltGot));
+
+  PltRelSec = findNotEmptySectionByAddress(Obj, FileName, *DtJmpRel);
+  if (!PltRelSec)
+    return createError("There is no not empty RELPLT section at 0x" +
----------------
jhenderson wrote:
> These two cases don't appear to have tests?
> 
> Also, the errors should be "not empty" -> "non-empty" and have lower-case first letters.
Oh, right. I've missed them for unknown reason. I've added tests for these 2.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83225/new/

https://reviews.llvm.org/D83225