[PATCH] D83137: [SVE][CodeGen] Legalisation of masked loads and stores

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

The patch overall looks good to me - just a question about the assert!



================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7135
   if (IsCompressedMemory) {
+    assert(!DataVT.isScalableVector() &&
+           "Cannot currently handle compressed memory with scalable vectors");
----------------
Do we know if this is something we catch earlier and hence should never get here? I just wonder if here it's not really an assert that something went wrong with the code, but perhaps we just hit a case we don't support yet? If it's just because we don't support it yet, instead of asserting we could do:

if (DataVT.isScalableVector())
  report_fatal_error("Cannot currently handle compressed memory with scalable vectors");


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83137/new/

https://reviews.llvm.org/D83137