[PATCH] D83225: [llvm-readobj] - Refactor the MipsGOTParser<ELFT> to stop using report_fatal_error().

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-plt.test:64
+# GNU-NEXT:   0041081c 004007c0 00000000 FUNC    UND puts
+# GNU-NEXT:   00410820 004007c0 00000000 FUNC    UND __libc_start_main
+
----------------
MaskRay wrote:
> `# ` prepending can be committed separately.
+1 to this (in both tests)


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3077-3084
+  if (!PltSec)
+    return createError("There is no not empty PLTGOT section at 0x " +
+                       Twine::utohexstr(*DtMipsPltGot));
+
+  PltRelSec = findNotEmptySectionByAddress(Obj, FileName, *DtJmpRel);
+  if (!PltRelSec)
+    return createError("There is no not empty RELPLT section at 0x" +
----------------
These two cases don't appear to have tests?

Also, the errors should be "not empty" -> "non-empty" and have lower-case first letters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83225/new/

https://reviews.llvm.org/D83225