[PATCH] D83225: [llvm-readobj] - Refactor the MipsGOTParser<ELFT> to stop using report_fatal_error().

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Some nits.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-plt.test:64
+# GNU-NEXT:   0041081c 004007c0 00000000 FUNC    UND puts
+# GNU-NEXT:   00410820 004007c0 00000000 FUNC    UND __libc_start_main
+
----------------
`# ` prepending can be committed separately.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3024
+  if (!DtPltGot)
+    return createError("cannot find PLTGOT dynamic table tag");
+  if (!DtLocalGotNum)
----------------
The canonical term is dynamic tag, not dynamic table tag.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83225/new/

https://reviews.llvm.org/D83225