[PATCH] D83089: DomTree: Extract (mostly) read-only logic into type-erased base classes

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

Overall, this seems like a good idea to me. The amount of templated code started growing out of hand some time ago, to the point where it's really hard to make logically changes, especially in the generic updater code.

This part of the code is *very* performance sensitive and definitely needs benchmarking before moving forward. Have you tried doing some performance evaluation on this change? I suggest compiling a few mid to large size programs (e.g., sqlite, webassembly, opt, clang, rippled) and compiling them into whole-program bitcode, and then running `opt -O3` on this bitcode. This is pretty easy with gllvm <https://github.com/SRI-CSL/gllvm>; I can dig up my old instruction if that would help.

Nit: please fix the linter warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83089/new/

https://reviews.llvm.org/D83089