[PATCH] D81166: [Matrix] Add matrix_nuw/matrix_nsw operand bundles for matrix.multiply.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 17:13:57 PDT 2020


reames added a comment.

(drive by comments only, please don't block on me)

Reading over this, I find myself wondering if this is actually matrix specific.  Would it make sense to have a means to declare the operations in an reduce.add are nsw/nuw?

As a semantic clarification, does the nsw/nuw markers on the matrix make any assumptions about order of operations?



================
Comment at: llvm/docs/LangRef.rst:2268
+``@llvm.matrix.multiply.*`` intrinsic and at most one of each matrix operand
+bundle can be attached to a call.
+
----------------
The LangRef text is not sufficient to describe the syntax.  I know this only because I went and read your verifier changes.  Please clarify, ideally with an example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81166/new/

https://reviews.llvm.org/D81166





More information about the llvm-commits mailing list