[PATCH] D83185: [Attributor] Introduce Attribute seed allow list.
Kuter Dinel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 6 15:27:43 PDT 2020
kuter added a comment.
In D83185#2134444 <https://reviews.llvm.org/D83185#2134444>, @uenoku wrote:
> In D83185#2134395 <https://reviews.llvm.org/D83185#2134395>, @kuter wrote:
>
> > In D83185#2134275 <https://reviews.llvm.org/D83185#2134275>, @uenoku wrote:
> >
> > > Either is fine but I think it is more natural to forbid an empty list.
> >
> >
> > Do you mean returning a error if a empty `--attributor-seed-allow-list` option is present ?
> > Currently the size of list is being used to tell if a list is present or not.
> > I think I can use `getNumOccurrences()` to replace this behaviour .
>
>
> Yes, I think replacing ZeroOrMore with OneOrMore is enoguh
I think `cl::OneOrMore` causes a error to be generated if the option is not specified.
That would make it mandatory to have a atleast one `--attributor-seed-allow-list` parameter for every invocation of
opt
https://llvm.org/docs/CommandLine.html
> The cl::OneOrMore modifier indicates that the option must be specified at least one time.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83185/new/
https://reviews.llvm.org/D83185
More information about the llvm-commits
mailing list