[PATCH] D83185: [Attributor] Introduce Attribute seed allow list.
Hideto Ueno via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 6 15:23:43 PDT 2020
uenoku added a comment.
In D83185#2134395 <https://reviews.llvm.org/D83185#2134395>, @kuter wrote:
> In D83185#2134275 <https://reviews.llvm.org/D83185#2134275>, @uenoku wrote:
>
> > Either is fine but I think it is more natural to forbid an empty list.
>
>
> Do you mean returning a error if a empty `--attributor-seed-allow-list` option is present ?
> Currently the size of list is being used to tell if a list is present or not.
> I think I can use `getNumOccurrences()` to replace this behaviour .
Yes, I think replacing ZeroOrMore with
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83185/new/
https://reviews.llvm.org/D83185
More information about the llvm-commits
mailing list