[PATCH] D83092: DomTree: Add findSiblingOfUncle helper

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Support/GenericDomTree.cpp:220
+/// the degenerate case where \p A itself is a sibling of \p Uncle.
+const GenericDomTreeNodeBase *GenericDominatorTreeBase::findSiblingOfUncle(
+    const GenericDomTreeNodeBase *A,
----------------
nhaehnle wrote:
> arsenm wrote:
> > I'm not sure these are the right family analogies. This could also find a great uncle, or the same parent.
> Fair enough, do you have a suggestion for a better name? `findSiblingOfNthUncle` perhaps?
I don't really have a better idea. The comment could maybe explain more of the cases it can encounter? "some ancestor" is a bit vague.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83092/new/

https://reviews.llvm.org/D83092