[PATCH] D83092: DomTree: Add findSiblingOfUncle helper

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle marked an inline comment as done.
nhaehnle added inline comments.


================
Comment at: llvm/lib/Support/GenericDomTree.cpp:220
+/// the degenerate case where \p A itself is a sibling of \p Uncle.
+const GenericDomTreeNodeBase *GenericDominatorTreeBase::findSiblingOfUncle(
+    const GenericDomTreeNodeBase *A,
----------------
arsenm wrote:
> I'm not sure these are the right family analogies. This could also find a great uncle, or the same parent.
Fair enough, do you have a suggestion for a better name? `findSiblingOfNthUncle` perhaps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83092/new/

https://reviews.llvm.org/D83092