[llvm] d7ea6ce - [Support] fix user_cache_directory on mac

Sam McCall via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 11:59:06 PDT 2020


This is a compile fix for cd209f1a3790, which is tested including on Mac.
The #ifdef __APPLE__ part didn't compile, and if it did the test wouldn't
have passed. I didn't have a Mac to test on.
(Typo in commit message: should be user_config_directory)

On Mon, Jul 6, 2020, 8:36 PM David Blaikie <dblaikie at gmail.com> wrote:

> Any chance of testing this? (maybe even a unit test? (even if it's
> uninteresting on other platforms, perhaps)?)
>
> On Mon, Jul 6, 2020 at 3:54 AM Sam McCall via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> >
> > Author: Sam McCall
> > Date: 2020-07-06T12:54:11+02:00
> > New Revision: d7ea6ce809a4413afb1edafa17ba291b39129f52
> >
> > URL:
> https://github.com/llvm/llvm-project/commit/d7ea6ce809a4413afb1edafa17ba291b39129f52
> > DIFF:
> https://github.com/llvm/llvm-project/commit/d7ea6ce809a4413afb1edafa17ba291b39129f52.diff
> >
> > LOG: [Support] fix user_cache_directory on mac
> >
> > Added:
> >
> >
> > Modified:
> >     llvm/lib/Support/Unix/Path.inc
> >
> > Removed:
> >
> >
> >
> >
> ################################################################################
> > diff  --git a/llvm/lib/Support/Unix/Path.inc
> b/llvm/lib/Support/Unix/Path.inc
> > index c35db79cbd8a..d91b269cc6d3 100644
> > --- a/llvm/lib/Support/Unix/Path.inc
> > +++ b/llvm/lib/Support/Unix/Path.inc
> > @@ -1193,7 +1193,7 @@ bool user_config_directory(SmallVectorImpl<char>
> &result) {
> >  #ifdef __APPLE__
> >    // Mac: ~/Library/Preferences/
> >    if (home_directory(result)) {
> > -    append("Library", "Preferences");
> > +    append(result, "Library", "Preferences");
> >      return true;
> >    }
> >  #else
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200706/8b0d733b/attachment.html>


More information about the llvm-commits mailing list