<div dir="auto">This is a compile fix for cd209f1a3790, which is tested including on Mac.<div dir="auto">The #ifdef __APPLE__ part didn't compile, and if it did the test wouldn't have passed. I didn't have a Mac to test on.</div><div dir="auto">(Typo in commit message: should be user_config_directory)</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 6, 2020, 8:36 PM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Any chance of testing this? (maybe even a unit test? (even if it's<br>
uninteresting on other platforms, perhaps)?)<br>
<br>
On Mon, Jul 6, 2020 at 3:54 AM Sam McCall via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
><br>
> Author: Sam McCall<br>
> Date: 2020-07-06T12:54:11+02:00<br>
> New Revision: d7ea6ce809a4413afb1edafa17ba291b39129f52<br>
><br>
> URL: <a href="https://github.com/llvm/llvm-project/commit/d7ea6ce809a4413afb1edafa17ba291b39129f52" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/d7ea6ce809a4413afb1edafa17ba291b39129f52</a><br>
> DIFF: <a href="https://github.com/llvm/llvm-project/commit/d7ea6ce809a4413afb1edafa17ba291b39129f52.diff" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/d7ea6ce809a4413afb1edafa17ba291b39129f52.diff</a><br>
><br>
> LOG: [Support] fix user_cache_directory on mac<br>
><br>
> Added:<br>
><br>
><br>
> Modified:<br>
>     llvm/lib/Support/Unix/Path.inc<br>
><br>
> Removed:<br>
><br>
><br>
><br>
> ################################################################################<br>
> diff  --git a/llvm/lib/Support/Unix/Path.inc b/llvm/lib/Support/Unix/Path.inc<br>
> index c35db79cbd8a..d91b269cc6d3 100644<br>
> --- a/llvm/lib/Support/Unix/Path.inc<br>
> +++ b/llvm/lib/Support/Unix/Path.inc<br>
> @@ -1193,7 +1193,7 @@ bool user_config_directory(SmallVectorImpl<char> &result) {<br>
>  #ifdef __APPLE__<br>
>    // Mac: ~/Library/Preferences/<br>
>    if (home_directory(result)) {<br>
> -    append("Library", "Preferences");<br>
> +    append(result, "Library", "Preferences");<br>
>      return true;<br>
>    }<br>
>  #else<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>