[PATCH] D83046: [LiveDebugValues] 1/4 Install an implementation-picking LiveDebugValues pass

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Neat! Could you please clang-format the diff and add in license headers?



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:51
+
+  LDVImpl *TheImpl;
+};
----------------
Can this remain private?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:69
+  delete TheImpl;
+}
+
----------------
nit, this seems simpler to just inline into the class definition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83046/new/

https://reviews.llvm.org/D83046