[PATCH] D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added a comment.

I think this patch is getting close.  A couple more comments from me.



================
Comment at: llvm/lib/Target/PowerPC/PPCMCInstLower.cpp:92
+  else if (MO.getTargetFlags() == (PPCII::MO_TLS | PPCII::MO_PCREL_FLAG))
+    RefKind = MCSymbolRefExpr::VK_PPC_TLS_PCREL;
 
----------------
I would move the setting of `VK_PPC_TLS_PCREL` into the switch above.
The `PPCII::MO_TLS` is not really a flag and with the current code we set `RefKind = MCSymbolRefExpr::VK_PPC_TLS` and then we set it to `MCSymbolRefExpr::VK_PPC_TLS_PCREL` afterward.


================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-tls-initial-exec.ll:6
+; RUN:   -mcpu=future -ppc-asm-full-reg-names --filetype=obj < %s | \
+; RUN:   llvm-objdump --mcpu=future -dr - | FileCheck %s --check-prefix=CHECK-O
+
----------------
nit:
Use `mcpu=pwr10`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81947/new/

https://reviews.llvm.org/D81947