[PATCH] D83111: [X86-64] Support Intel AMX Intrinsic

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/x86-target-features.c:236
+
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mamx-tile %s -### -o %t.o 2>&1 | FileCheck -check-prefix=AMX-TILE %s
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mno-amx-tile %s -### -o %t.o 2>&1 | FileCheck -check-prefix=NO-AMX-TILE %s
----------------
xiangzhangllvm wrote:
> MaskRay wrote:
> > `--check-prefix=` is much more common than other forms (e.g. `-check-prefix `)
> > 
> > please fix other occurrences as well
> > 
> > Also, don't add extra spaces like `FileCheck  --check-prefix`
> Oh, seem right, but do you think a AMX patch is better to change the codes which have no relation with it ?
> And, sorry,not much understand "FileCheck  --check-prefix", does you mean 2 spaces between "FileCheck" and "--check-prefix" ?
You wrote `FileCheck  -check-prefix` below.

Please use `FileCheck --check-prefix=`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83111/new/

https://reviews.llvm.org/D83111