[PATCH] D83029: [SVE] Fix invalid assert in expand_DestructiveOp.
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 4 02:41:00 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7356b4243ad9: [SVE] Fix invalid assert in expand_DestructiveOp. (authored by paulwalker-arm).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83029/new/
https://reviews.llvm.org/D83029
Files:
llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
llvm/test/CodeGen/AArch64/sve-pseudos-expand-undef.mir
Index: llvm/test/CodeGen/AArch64/sve-pseudos-expand-undef.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/AArch64/sve-pseudos-expand-undef.mir
@@ -0,0 +1,22 @@
+# RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve -run-pass=aarch64-expand-pseudo -simplify-mir -verify-machineinstrs %s -o - | FileCheck %s
+---
+name: add_x
+alignment: 4
+tracksRegLiveness: true
+liveins:
+ - { reg: '$p0' }
+ - { reg: '$z0' }
+frameInfo:
+ maxCallFrameSize: 0
+body: |
+ bb.0:
+ liveins: $p0, $z0
+
+ ; CHECK: add_x
+ ; CHECK-NOT: MOVPRFX
+ ; CHECK: $z0 = FADD_ZPmZ_S renamable $p0, killed $z0, renamable $z0
+ ; CHECK-NEXT: RET
+ renamable $z0 = FADD_ZPZZ_UNDEF_S renamable $p0, renamable $z0, killed renamable $z0
+ RET_ReallyLR
+
+...
Index: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
===================================================================
--- llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
+++ llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
@@ -438,8 +438,6 @@
DOPRegIsUnique = true;
break;
}
-
- assert (DOPRegIsUnique && "The destructive operand should be unique");
#endif
// Resolve the reverse opcode
@@ -483,6 +481,9 @@
//
MachineInstrBuilder PRFX, DOP;
if (FalseZero) {
+#ifndef NDEBUG
+ assert(DOPRegIsUnique && "The destructive operand should be unique");
+#endif
assert(ElementSize != AArch64::ElementSizeNone &&
"This instruction is unpredicated");
@@ -495,6 +496,9 @@
// After the movprfx, the destructive operand is same as Dst
DOPIdx = 0;
} else if (DstReg != MI.getOperand(DOPIdx).getReg()) {
+#ifndef NDEBUG
+ assert(DOPRegIsUnique && "The destructive operand should be unique");
+#endif
PRFX = BuildMI(MBB, MBBI, MI.getDebugLoc(), TII->get(MovPrfx))
.addReg(DstReg, RegState::Define)
.addReg(MI.getOperand(DOPIdx).getReg());
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83029.275488.patch
Type: text/x-patch
Size: 1979 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200704/19ebb3b1/attachment.bin>
More information about the llvm-commits
mailing list