[PATCH] D83029: [SVE] Fix invalid assert in expand_DestructiveOp.
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 2 14:03:42 PDT 2020
sdesmalen accepted this revision.
sdesmalen added a comment.
LGTM
================
Comment at: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:481
if (FalseZero) {
+#ifndef NDEBUG
+ assert(DOPRegIsUnique && "The destructive operand should be unique");
----------------
paulwalker-arm wrote:
> sdesmalen wrote:
> > Why are you wrapping this in `#ifndef NDEBUG` ?
> The definition of DOPRegIsUnique is protected by NDEBUG.
Okay that makes sense, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83029/new/
https://reviews.llvm.org/D83029
More information about the llvm-commits
mailing list