[PATCH] D83052: [PowerPC][Power10] Add Vector Insert Instruction Definitions and MC Tests

[Amy Kwan via Phabricator via llvm-commits]

amyk marked 2 inline comments as done.
amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:231
+// "/ UIM" (unused bit followed by a 4-bit immediate)
+class VX_VRT5_UIM5_RB5<bits<11> xo, string opc, list<dag> pattern>
+  : VXForm_1<xo, (outs vrrc:$VRT), (ins vrrc:$VRTi, u4imm:$UIM, g8rc:$RB),
----------------
lei wrote:
> Was this meant to be `VXForm_VRT5_UIM5_RB5`?
I'll need to fix that, thanks.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:764
+  def VINSD : VX_VRT5_UIM5_RB5<463, "vinsd", []>;
+  def VINSBVLX : VXForm_1<15, (outs vrrc:$vD), (ins vrrc:$vDi, g8rc:$rA,
+                          vrrc:$vB), "vinsbvlx $vD, $rA, $vB", IIC_VecGeneral,
----------------
lei wrote:
> Why not define a class similar to `VX_VRT5_UIM5_RB5` to be used for the instruction def below?
Sorry, I originally intended to do that since we have `vinsw` and `vinsd` defined with a multiclass, but not sure why I didn't... Will fix. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83052/new/

https://reviews.llvm.org/D83052