[PATCH] D82435: [DWARFYAML][debug_gnu_*] Add the missing context `IsGNUStyle`. NFC.
Xing GUO via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 22:43:09 PDT 2020
Higuoxing added inline comments.
================
Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:37
Error emitPubSection(raw_ostream &OS, const PubSection &Sect,
- bool IsLittleEndian);
+ bool IsLittleEndian, bool IsGNUStyle = false);
Error emitDebugInfo(raw_ostream &OS, const Data &DI);
----------------
MaskRay wrote:
> Mentioning GNUPub might be better
>
>
Sorry, what do you mean by saying "mentioning" here? Does it mean that you want me to rename the variable `IsGNUStyle` to `IsGNUPubSec`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82435/new/
https://reviews.llvm.org/D82435
More information about the llvm-commits
mailing list