[PATCH] D82435: [DWARFYAML][debug_gnu_*] Add the missing context `IsGNUStyle`. NFC.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 21:06:06 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:37
 Error emitPubSection(raw_ostream &OS, const PubSection &Sect,
-                     bool IsLittleEndian);
+                     bool IsLittleEndian, bool IsGNUStyle = false);
 Error emitDebugInfo(raw_ostream &OS, const Data &DI);
----------------
Mentioning GNUPub might be better




================
Comment at: llvm/include/llvm/ObjectYAML/DWARFYAML.h:118
+struct DWARFContext {
+  bool IsGNUStylePubSec = false;
+};
----------------
Minor nit: IsGNUPubSec is probably sufficient.

GNUPub is derived from `.debug_gnu_pubnames .debug_gnu_pubtypes`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82435/new/

https://reviews.llvm.org/D82435





More information about the llvm-commits mailing list