[PATCH] D83020: [AMDGPU] Avoid using s_cmpk when src0 is not register

[Ruiling, Song via Phabricator via llvm-commits]

ruiling marked an inline comment as done.
ruiling added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/cmp_shrink.mir:5
+# GCN: bb.0:
+# GCN-NOT: S_CMPK_GT_I32
+---
----------------
arsenm wrote:
> positive checks are more useful. Also you can just generate these checks. Can you reproduce this with an IR test too?
will try positive check, how to generate the checks? could you give a little bit more info? The original test case that hit the issue is over-complex I think. Normally, a constant expression at IR level is easy to be optimized off by the middle-end. so I think a .mir test is enough for this issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83020/new/

https://reviews.llvm.org/D83020