[PATCH] D82673: [ModuloSchedule] Make PeelingModuloScheduleExpander inheritable.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 1 10:15:49 PDT 2020
dblaikie added a comment.
Adding an extension point with no testing inside LLVM seems a bit problematic - is there no existing target that could use this? Or a reasonable scale of unit test that could exercise this extension point without a full-blown target?
(also this produced a warning about the fact that this type doesn't have a virtual dtor - was fixed by @jfb in c7586444ca787c3845ac4ad0bd603709f2abbb0f <https://reviews.llvm.org/rGc7586444ca787c3845ac4ad0bd603709f2abbb0f> )
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82673/new/
https://reviews.llvm.org/D82673
More information about the llvm-commits
mailing list