[PATCH] D82673: [ModuloSchedule] Make PeelingModuloScheduleExpander inheritable.

[JF Bastien via Phabricator via llvm-commits]

jfb added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ModuloSchedule.h:286
+
+  virtual void expand();
+
----------------
This generates the following diagnostic when building:
```
llvm/include/llvm/CodeGen/ModuloSchedule.h:279:7: warning: 'llvm::PeelingModuloScheduleExpander' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class PeelingModuloScheduleExpander {
      ^
```
If you ever destroy a derived class while holding a `PeelingModuloScheduleExpander*` you'll have a bad time.

Fixed here:
https://github.com/llvm/llvm-project/commit/c7586444ca787c3845ac4ad0bd603709f2abbb0f


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82673/new/

https://reviews.llvm.org/D82673