[PATCH] D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:1483
             3, 9, DW_LNE_set_address,
             ValueAndLengths{{0x1234567890abcdef, LineTable::Quad}},
+            "DW_LNE_set_address", None,
----------------
It's possible you may have misunderstood what we were suggesting. Rather than adding another argument, I think @ikudrin and I were thinking of changing the `0x1234567890abcdef` to `0x1234567878563412`, and so on in the other tests, so that the error message would be the same regardless of endianness. That way the test is completely agnostic of endianness and there's no need to query the host/target.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:1488
             10, 9, DW_LNE_set_address,
             ValueAndLengths{{0x1234567890abcdef, LineTable::Quad}},
             "DW_LNE_set_address (<parsing error> ef cd ab 90 78 56 34)",
----------------
This would be the same as above.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:1535
             6, 5, /*Unknown=*/0x7f,
             ValueAndLengths{{0x12345678, LineTable::Long}},
             "Unrecognized extended op 0x7f length 5 (<parsing error> 78 56 34)",
----------------
This would be `0x12343412`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82827/new/

https://reviews.llvm.org/D82827