[PATCH] D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds

Tue Jun 30 14:41:39 PDT 2020

daltenty added a comment.

In D82827#2122786 <https://reviews.llvm.org/D82827#2122786>, @daltenty wrote:

> In D82827#2122013 <https://reviews.llvm.org/D82827#2122013>, @jhenderson wrote:
>
> > In D82827#2121798 <https://reviews.llvm.org/D82827#2121798>, @ikudrin wrote:
> >
> > > The patch looks appropriate, but now I think that maybe it would have been enough to simply use symmetrical constants for these particular tests?
> >
> >
> > Testing endianness behaviour of the code under test is not what the original change was about, so getting rid of this byte-swapping code entirely would make the testing simpler, I agree. @daltenty, are you happy to do that? It should be a fairly straightforward change, I believe.
>
>
> That makes sense to me, I will update to remove the byteswap and add a set of symmetrical constants for the big-endian case.

Ended up adding an optional big endian version of the message instead, as I think it comes out a bit cleaner than constructing an optional version of the input using the symmetrical constant, but let me know if you have a preference for that version instead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82827/new/

https://reviews.llvm.org/D82827