[PATCH] D82847: [CMAKE] Fix 'clean' target not working

[Pushpinder Singh via Phabricator via llvm-commits]

pdhaliwal marked an inline comment as done.
pdhaliwal added inline comments.


================
Comment at: llvm/include/llvm/Support/CMakeLists.txt:26
+if (fake_version_inc)
+  add_custom_command(OUTPUT "${version_inc}" "${fake_version_inc}"
+    DEPENDS "${llvm_vc}" "${generate_vcs_version_script}"
----------------
phosek wrote:
> Can you use `${generated_files}` here as well for `OUTPUT` and avoid duplicating this command?
Hi, I had initially tried using `${generated_files}` for OUTPUT as well but then ninja started complaining with following error (only in cases where llvm_vc was not defined)

```
ninja: error: 'include/llvm/Support/VCSRevision.h', needed by 'include/llvm/Support/CMakeFiles/llvm_vcsrevision_h', missing and no known rule to make it
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82847/new/

https://reviews.llvm.org/D82847