[PATCH] D82847: [CMAKE] Fix 'clean' target not working
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 30 10:50:14 PDT 2020
phosek added inline comments.
================
Comment at: llvm/include/llvm/Support/CMakeLists.txt:26
+if (fake_version_inc)
+ add_custom_command(OUTPUT "${version_inc}" "${fake_version_inc}"
+ DEPENDS "${llvm_vc}" "${generate_vcs_version_script}"
----------------
Can you use `${generated_files}` here as well for `OUTPUT` and avoid duplicating this command?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82847/new/
https://reviews.llvm.org/D82847
More information about the llvm-commits
mailing list