[PATCH] D71786: RFC: [Support] On Windows, add optional support for rpmalloc

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 30 14:09:23 PDT 2020


MaskRay added a comment.

In D71786#2123288 <https://reviews.llvm.org/D71786#2123288>, @russell.gallop wrote:

> I notice that the improvements to rpmalloc for LLVM are still under discussion (https://github.com/mjansson/rpmalloc/issues/150) and targetted at rpmalloc v1.4.1.
>
> Is the version in this review based on rpmalloc v1.4.0?
>
> Is the plan to land this version as it fixes the concurrency issue then update to v1.4.1 to improve memory usage?
>
> I wonder if it's possible to get this in for LLVM 11. Is it just wanting an okay on the licensing?


First, there are of course license concerns. You'll need to find someone comfortable and authoritative approving this.

Second, adding a malloc implementation does not seem suitable to me. I think this particular comment should be addressed https://reviews.llvm.org/D71786#1984285
Is replacing the malloc implementation on difficult on Windows that the compiler has to ship a copy?

(BTW, have folks tried https://github.com/richfelker/mallocng-draft ? I hope it is not too difficult porting it to Windows...)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786





More information about the llvm-commits mailing list